Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the science tech fab #2624

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 27, 2024

About the PR

[Removes the science techfab, as it's rendered useless compared to the protolathe], if you have a sci ship you will be using a normal [functional] Protolathe that [provides] the same [function.]

Why / Balance

Its a copy paste machine, [it is superseded by the protolathe and not needed].

How to test

Buy gourd, see 2 protolathes, asked yourself why it was even mapped to begin with.

Media

N/A

Requirements

Breaking changes

N/A

Changelog

  • remove: Science techfabs have been removed in favor of using the protolathe.

@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews No C# YML and removed Status: Needs Review This PR is awaiting reviews labels Dec 27, 2024
@whatston3
Copy link
Contributor

Honestly, fair.

@whatston3
Copy link
Contributor

Might be worth replacing that extra science techfab with a machine frame on the gourd.

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 27, 2024

Might be worth replacing that extra science techfab with a machine frame on the gourd.

Fixed

@whatston3
Copy link
Contributor

Given that the three ships that have them also have mapped protolathes, this seems fine to me. Caution downstream, I suppose.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - if others have stronger feelings for/against, all ears.

@dvir001 dvir001 merged commit e84aa8a into new-frontiers-14:master Dec 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants